Skip to content

chore(plugin-timeline): retire the five dead timeline.relative.* default rows (objectui#7874) - #7887

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-7874-timeline-relative-dead-defaults
Sep 6, 2026
Merged

chore(plugin-timeline): retire the five dead timeline.relative.* default rows (objectui#7874)#7887
os-sam merged 1 commit into
mainfrom
claude/issue-7874-timeline-relative-dead-defaults

Conversation

@claude

@claude claude Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Fixes #7874

The PM ruling is delete, as residue: the five timeline.relative.* rows in TIMELINE_DEFAULT_TRANSLATIONS have no reachable path, and no product behaviour attaches to code nothing can reach. Wiring relative dates through t() would be a new feature (copy, plural rules, ten-pack coverage), not the other half of this question.

One row deleted from packages/plugin-timeline/src/useTimelineTranslation.ts, a retirement pin added beside it, and an empty-frontmatter changeset declaring that nothing releases. Measured on origin/main at 83fe6e741; branch head 3ac057309.

1. The five rows, transcribed verbatim

The deletion is safe because it is reversible, and it is reversible because the content is written down here (and in the pin test, and in the changeset) - not because "it is in git history somewhere":

'timeline.relative.today': 'Today',
'timeline.relative.tomorrow': 'Tomorrow',
'timeline.relative.yesterday': 'Yesterday',
'timeline.relative.inDays': 'In {{n}} days',
'timeline.relative.daysAgo': '{{n}} days ago',

2. Escape hatch: "zero callers" re-verified on current main, by PREFIX, with a positive control

Re-measured on this branch's base rather than inherited from the card.

By prefix, not by the five full key names, because a dynamically assembled key (t(`timeline.relative.${x}`)) is invisible to a literal search for the complete names. Two passes, both returning exactly the five declaration lines and nothing else:

Pass Command shape Result
tracked + untracked, node_modules / dist excluded git grep -n --untracked -I -e 'timeline\.relative' 5 hits, all in useTimelineTranslation.ts:26-30
whole worktree incl. ignored build outputs, only node_modules and .git excluded rg -n --no-ignore --hidden -g '!node_modules' -g '!.git' 'timeline\.relative' the same 5 lines

Positive control - the same command shape, on keys that DO have callers. A search that has not been shown to fire is not a measurement:

Key searched Call site the search returned
timeline.bucket.overdue ObjectTimeline.tsx:421
timeline.scale.week renderer.tsx:163 (plus its pin test)
timeline.gantt.rowLabel renderer.tsx:1499

Dynamic assembly, checked as its own question, not as a by-product of the prefix search:

  • No template-literal translator call exists anywhere in the tree: git grep -nE '\bt\(' -- 'packages//src' 'apps//src'` returns nothing (exit 1).
  • No concatenated or template-built timeline.* key: `timeline., 'timeline.' +, "timeline." +, timeline.${ - every hit is prose in a comment or a spec key like timeline.startDateField, none of them a key handed to t().
  • The suffix side too, in case a prefix lived in a variable: the only tree-wide hit for a bare 'daysAgo' is apps/console/src/pages/system/ApprovalsInboxPage.tsx:653, whose local tr resolves t(`approvalsInbox.${key}`) - a different namespace, and its own module-local defaults.
  • Nobody reads the table wholesale either: every importer of TIMELINE_DEFAULT_TRANSLATIONS indexes a named key (timeline.scale.*, timeline.gantt.*); none iterates it or pins its size.

Why they are residue, positively rather than by absence. Day-granularity relative phrases are produced by formatRelativeDate / formatRelativeDays in @object-ui/core (utils/date-display.ts) through Intl.RelativeTimeFormat, whose output for the en locale is literally "Today" / "Tomorrow" / "Yesterday" / "in 3 days" / "3 days ago". A formatter that derives the words from the locale needs no copy row in any pack - that is what left these five behind.

Also worth recording: TIMELINE_DEFAULT_TRANSLATIONS and translateTimelineDefault are not re-exported from the package entry (src/index.tsx re-exports ./renderer, which imports them without re-exporting). No consumer of the published tarball can name them, so the deletion cannot move a published API surface either.

3. The three instruments: none of them moved

Expected none, measured none. Before and after are the same commands on the same tree, run either side of the edit:

Instrument Before After Delta
check:i18n-dead-keys (pack keys with no call site) 2967 pack keys, 15575 referenced, 361 candidates / 46 namespaces, 114 CONFIRMED, 247 NEEDS-REVIEW identical diff of the two full reports is empty - byte-identical, all 1143 lines
pack parity (all-locales-key-parity.test.ts) 1 file, 32 tests passed 1 file, 32 tests passed 0
class-1 missing-key (check:i18n-keys) 3938 call sites, 2777 pack-backed, 2728/2728 literal keys resolve identical diff of the two full reports is empty

That is exactly the card's reading, and it is why these rows survived: class 1 judges call sites (they had none), parity compares packs to each other (ten packs identically lacking a key is full parity), and the reverse sweep judges pack keys (these were in no pack). They were caught by objectui#7567's census printing its abstention count - 5 of 846 factory-table rows - not by any rule judging them.

Two neighbours measured for the same reason, also unmoved: check:i18n-drift reports 0 en value(s) changed (0 key(s) added, 0 removed), and fallback-placeholder-spelling-3512.test.ts - which walks this exact table - stays green.

One reading the card did not have, and it goes the other way. There IS a rule in this repo that rejects a defaults row whose key no pack defines: defaults-maps-mirror-en-pack.test.tsx (objectui#4401), "every row names a key the en pack actually defines". It did not fire because its MAPS list is three hand-written entries - detail, list, designer - and TIMELINE_DEFAULT_TRANSLATIONS is not among them. So the blind spot is a fourth gate's coverage, not a fourth gate's absence. Filed separately as #7884; out of scope here, and it changes nothing about this deletion.

4. Changeset: the checker's verdict, quoted

Not guessed. node scripts/check-changeset-presence.mjs first refused the change with no changeset:

❌  1 source file(s) of 1 released package(s) changed, and this change adds no changeset:

      @object-ui/plugin-timeline
          packages/plugin-timeline/src/useTimelineTranslation.ts
...
    If this change really should release nothing, say so — that is a pass, not a
    workaround. [quote trimmed here: the next line names a changeset file with an
    EMPTY frontmatter, spelled with angle brackets that GitHub's body sanitizer eats]

.changeset/7874-timeline-relative-defaults-retired.md was added with an empty frontmatter, because nothing reachable changes and nothing published moves (see the export note in section 2). The checker then answered, verbatim:

Compared the working tree with 83fe6e741 (merge-base with origin/main): 1 file(s) changed, 1 of them published source of a package the release covers, 0 of them a manifest whose published contract moved, 0 under a package changesets ignores, 1 changeset(s) added.
✅  1 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s): .changeset/7874-timeline-relative-defaults-retired.md.
    Every one of them has an EMPTY frontmatter — declared as releasing nothing, which
    is the explicit exemption and a complete answer to this gate.

check-changeset-no-major.mjs: ✅ No changeset declares a major bump.

5. Clause-② stays no

No key added, no published export moved, no gate predicate or scan population touched. The governed-surface check agrees, on this commit's three paths:

✅ NOT GOVERNED — 3 path(s) checked against 5 governed surface(s); none matched.
   An ordinary pull request: the normal review and merge-queue route applies.

The pin, and the ablation that shows it fires

packages/plugin-timeline/src/__tests__/timeline-relative-defaults-retired-7874.test.ts follows the retirement-pin series (objectui#4392 / #4730 / #5504 / #6310 / #7125): the retired rows asserted absent by key and by prefix, the exported translateTimelineDefault asserted to answer a retired key with the raw key rather than its old string, and surviving-sibling assertions so a green cannot be bought by deleting the neighbourhood. timeline.bucket.today and timeline.bucket.tomorrow carry the same two strings the retired rows did, so a sweep by VALUE takes them out as collateral - they are pinned for exactly that reason.

The pin exists because no gate can see a dead row come back: each of them runs call site to key, pack to pack, or pack to call site.

Ablation - the rows re-inserted, then restored, with both legs proven on disk rather than by an exit code. No rebuild leg is needed here and none was run: the test imports ../useTimelineTranslation by relative path inside its own package, so vitest compiles the source, with no exports/dist indirection to go stale.

HEAD blob for packages/plugin-timeline/src/useTimelineTranslation.ts = c02661e28d40040d0168a2c7650bd00c114beb66
mutation written
injected rows on disk = 5 ; blob now 67ff97460aa6b3a621d8a4e506a57bea37a4fe71 (HEAD c02661e28d40040d0168a2c7650bd00c114beb66)
ABLATION_TEST_EXIT=1 (expect non-zero = the pin fires)
     × carries no `timeline.relative.*` row, by key and by prefix
     × answers a retired key with the key itself, not with its old string
 Test Files  1 failed (1)
      Tests  2 failed | 2 passed (4)
restored blob = c02661e28d40040d0168a2c7650bd00c114beb66 ; rows on disk = 0 ; git diff HEAD = ''
RESTORE VERIFIED: blob matches HEAD, git diff HEAD empty, 0 retired rows on disk

The mutating script carried trap restore EXIT INT TERM with an absolute path resolved from git rev-parse --show-toplevel, and both legs were verified by state (blob hash, row count, empty git diff HEAD), never by the editor's exit code.

What ran, on the pushed SHA 3ac057309 with git diff HEAD empty

Command Verdict line
pnpm exec vitest run packages/plugin-timeline/ packages/i18n/src/__tests__/all-locales-key-parity.test.ts packages/i18n/src/__tests__/fallback-placeholder-spelling-3512.test.ts packages/app-shell/src/__tests__/defaults-maps-mirror-en-pack.test.tsx Test Files 26 passed (26) / Tests 353 passed (353) (the timeline package alone: 23 files / 291 tests, from 22 / 287 before)
pnpm --filter @object-ui/plugin-timeline run type-check exit 0 (tsc --noEmit && tsc -p tsconfig.test.json). --listFiles confirms the new test file is IN the program - a typecheck that excluded it would be a true sentence about nothing
check:changeset-presence / check:changeset-no-major / check:control-bytes / check:i18n-keys / check:i18n-drift / check:i18n-dead-keys / check:unreferenced-sources / governed-queue-guard all exit 0; every exit code captured by redirecting to a file first, never read through a pipe
eslint --no-inline-config on the two changed source files 2 files linted, 0 errors, 0 warnings

On the lint narrowing (two files rather than the repo sweep, which CI runs anyway): the population came from eslint's own resolution of the two paths, the file count is read off --format json, and this repo's flat config is not type-aware - tseslint.configs.recommended, no parserOptions.project and no projectService - so this diff cannot move the verdict on any file it does not touch. That makes the narrowing a measurement rather than a skip.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KbJQ1y1J12nZxYzFWhP8Q3


Generated by Claude Code

…fault rows (objectui#7874)

The five rows had no `en` leaf and no call site anywhere in the tree, so
`fallbackT` could never be asked for one — they rendered for nobody. Day
granularity relative phrases come from `formatRelativeDate` in `@object-ui/core`
through `Intl.RelativeTimeFormat`, which needs no copy row; that is what left
these behind.

Deleted rows, transcribed verbatim so the deletion is reversible from the record
rather than from git archaeology:

    'timeline.relative.today': 'Today',
    'timeline.relative.tomorrow': 'Tomorrow',
    'timeline.relative.yesterday': 'Yesterday',
    'timeline.relative.inDays': 'In {{n}} days',
    'timeline.relative.daysAgo': '{{n}} days ago',

A retirement pin replaces them: no i18n gate in this repo can see a dead row come
back (each runs call site -> key, pack -> pack, or pack -> call site), so the pin
is the only guard against a silent revival.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KbJQ1y1J12nZxYzFWhP8Q3
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 50 chunks) 3187.2 KB 3191.4 KB
Main entry chunk (gzip) 143.4 KB 350 KB
Entry file index-C-fwoV6J.js
Status PASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 15.67KB 5.75KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 5.13KB 2.35KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 510.60KB 116.20KB
core (index.js) 6.96KB 2.79KB
create-plugin (index.js) 10.08KB 3.26KB
data-objectstack (index.js) 182.08KB 50.62KB
fields (index.js) 242.44KB 61.25KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 4.28KB 1.75KB
i18n (index.js) 3.65KB 1.47KB
i18n (pickLocalized.js) 7.62KB 3.26KB
i18n (provider.js) 26.89KB 9.04KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 38.98KB 10.98KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 4.39KB 1.66KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 11.71KB 4.29KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 5.12KB 1.74KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 15.75KB 3.80KB
plugin-calendar (index.js) 47.87KB 13.31KB
plugin-charts (index.js) 70.92KB 19.75KB
plugin-chatbot (index.js) 196.19KB 46.37KB
plugin-dashboard (index.js) 132.88KB 34.69KB
plugin-designer (index.js) 212.86KB 43.19KB
plugin-detail (index.js) 250.55KB 64.06KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 132.87KB 32.66KB
plugin-gantt (index.js) 167.26KB 41.00KB
plugin-grid (index.js) 209.29KB 56.78KB
plugin-kanban (index.js) 52.71KB 14.55KB
plugin-list (index.js) 113.76KB 27.75KB
plugin-map (index.js) 20.44KB 6.78KB
plugin-markdown (index.js) 13.93KB 4.81KB
plugin-report (index.js) 43.59KB 11.97KB
plugin-timeline (index.js) 30.63KB 8.80KB
plugin-tree (index.js) 9.20KB 3.19KB
plugin-view (index.js) 85.24KB 20.94KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 81.07KB 26.86KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 2.32KB 1.24KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 5.41KB 2.34KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 4.93KB 2.24KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 20.57KB 5.88KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 10.35KB 3.60KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.74KB 1.41KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 4.73KB 2.28KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-sam
os-sam marked this pull request as ready for review September 6, 2026 01:40
@os-sam
os-sam added this pull request to the merge queue Sep 6, 2026
Merged via the queue into main with commit d9580f4 Sep 6, 2026
34 checks passed
@os-sam
os-sam deleted the claude/issue-7874-timeline-relative-dead-defaults branch September 6, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

finding(plugin-timeline/i18n): five timeline.relative.* defaults rows have no en key and no caller — invisible to every existing i18n gate

2 participants